Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: structured metadata not always passed down for processing deletes (backport k233) #15527

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: structured metadata not always passed down for processing deletes (backport k233) #15527

merged 1 commit into from
Dec 20, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 20, 2024

Backport a3808b6 from #15526

What this PR does / why we need it:
Structured metadata was not passed downstream when a delete request pipeline filter was processed for a query (only affected metric queries).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean @grafana-delivery-bot
fix: structured metadata not always passed down for processing deletes (
0486b4b 
#15526)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit a3808b6)
@loki-gh-app loki-gh-app bot added the backport label Dec 20, 2024
@loki-gh-app loki-gh-app bot requested a review from a team as a code owner December 20, 2024 20:58
@loki-gh-app loki-gh-app bot added size/XS type/bug Somehing is not working as expected labels Dec 20, 2024
@loki-gh-app loki-gh-app bot requested a review from slim-bean December 20, 2024 20:58
@slim-bean slim-bean merged commit 1a89e0e into k233 Dec 20, 2024
64 checks passed
@slim-bean slim-bean deleted the backport-15526-to-k233 branch December 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slim-bean